Skip to content

Fixed ARMv7 segmentation fault#68

Open
jakub-kocka wants to merge 6 commits intomainfrom
fix/armv7_segmentation_fault
Open

Fixed ARMv7 segmentation fault#68
jakub-kocka wants to merge 6 commits intomainfrom
fix/armv7_segmentation_fault

Conversation

@jakub-kocka
Copy link
Copy Markdown
Collaborator

@jakub-kocka jakub-kocka commented Apr 23, 2026

Description

This PR introduces enhanced checking of the wheels on S3 to not overwrite wheels we don't want to (mostly the same naming), e.g., ARMv7 "classic" and "legacy".

Also, for ARMv7, we do not require manylinux tags to not bundle the libraries to the wheel and prefer piwheels index before the official PyPI.

Related

Testing

We now do not force the ARMv7 wheels to produce manylinux wheels, so there is no need to bundle the libs to the wheels, which is the main cause of this issue - because of the library mismatch.

cffi wheel example:
image


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jakub-kocka jakub-kocka self-assigned this Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Warnings
⚠️ Please consider squashing your 6 commits (simplifying branch history).

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3ed2ab8

@jakub-kocka jakub-kocka force-pushed the fix/armv7_segmentation_fault branch from d0a5c2c to 6c2b3bf Compare April 24, 2026 11:25
@jakub-kocka jakub-kocka force-pushed the fix/armv7_segmentation_fault branch 2 times, most recently from c557c95 to c8e3f41 Compare April 27, 2026 08:46
@jakub-kocka jakub-kocka force-pushed the fix/armv7_segmentation_fault branch from c8e3f41 to d36a0f6 Compare April 27, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant